Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set limits on Istio racetest & integration test jobs. #12445

Merged
merged 1 commit into from
May 3, 2019
Merged

Set limits on Istio racetest & integration test jobs. #12445

merged 1 commit into from
May 3, 2019

Conversation

ozevren
Copy link
Contributor

@ozevren ozevren commented May 1, 2019

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 1, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @ozevren. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 1, 2019
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/testgrid sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels May 1, 2019
@ozevren
Copy link
Contributor Author

ozevren commented May 1, 2019

@utka Can you take a look?

@utka
Copy link
Contributor

utka commented May 1, 2019

Don't have permissions for k8s

@ozevren
Copy link
Contributor Author

ozevren commented May 1, 2019

I think if you give an honorary lgtm, I can persuade the folks on the reviewer line to ok to test and lgtm this. :)

@utka
Copy link
Contributor

utka commented May 1, 2019

/lgtm

@k8s-ci-robot
Copy link
Contributor

@utka: changing LGTM is restricted to assignees, and only kubernetes/test-infra repo collaborators may be assigned issues.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ozevren
Copy link
Contributor Author

ozevren commented May 1, 2019

@spiffxp, @shyamjvs Could you take a look? Me and @utka are both members of Istio org.

@ozevren
Copy link
Contributor Author

ozevren commented May 2, 2019

friendly ping.

@ozevren
Copy link
Contributor Author

ozevren commented May 2, 2019

@sebastienvas
Any chance you can shepherd this PR in?

Also, is there a less painful way of updating these files? Can we get a reviewer of our own for the Istio specific files? Should we consider moving the config out to our own repository? And hosting testgrid?

@ozevren ozevren closed this May 3, 2019
@ozevren ozevren reopened this May 3, 2019
@sebastienvas
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 3, 2019
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 9778b0c245ff6b3b967ba2785102c39c0d22a276

@sebastienvas
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 3, 2019
@sebastienvas
Copy link
Contributor

sebastienvas commented May 3, 2019 •
edited
Loading

/assign @michelle192837

@michelle192837
Copy link
Contributor

/approve

For less-painful commits; running your own TestGrid isn't possible at the moment, it's blocked on open-sourcing (#10409). It should be possible to split the TestGrid configs and have more individual OWNERs for those files, but someone needs to do the initial work for that (#10997)

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: michelle192837, ozevren

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 3, 2019
@k8s-ci-robot k8s-ci-robot merged commit 895df89 into kubernetes:master May 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shyamjvs shyamjvs Awaiting requested review from shyamjvs

@spiffxp spiffxp Awaiting requested review from spiffxp

Assignees

@sebastienvas sebastienvas

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/testgrid cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ozevren @k8s-ci-robot @utka @sebastienvas @michelle192837